Re: [RFC][PATCH 2/2] x86: Clean up default rethunk warning

[Peter Zijlstra]

On Tue, Oct 08, 2024 at 09:45:14AM -0700, Josh Poimboeuf wrote:
> On Tue, Oct 08, 2024 at 09:25:02AM +0200, Peter Zijlstra wrote:
> > On Mon, Oct 07, 2024 at 10:33:45AM -0700, Josh Poimboeuf wrote:
> > > On Mon, Oct 07, 2024 at 10:32:12AM +0200, Peter Zijlstra wrote:
> > > > Replace the funny __warn_thunk thing with a more regular
> > > > WARN_ON_ONCE(), and simplify the ifdeffery.
> > > > 
> > > > Notably this avoids RET from having recursive RETs (once from the
> > > > thunk and once from the C function) -- recursive RET makes my head
> > > > hurt for no good reason.
> > > 
> > > This could use an explanation for why the ifdefs can be removed and why
> > > the alternative can be removed.
> > 
> > The alternative is in the WARN_ONCE now.
> 
> Ah, sneaky... It should really be called WARN_ONCE_AFTER_ALTERNATIVES or
> something.

Yeah, I suppose it should.