Re: [usb?] possible deadlock in chaoskey_open

From: Edward Adam Davis
Date: Wed Oct 09 2024 - 04:47:24 EST


delay get the chaoskey_list_lock, avoid to circular locking dependency

#syz test

diff --git a/drivers/usb/misc/chaoskey.c b/drivers/usb/misc/chaoskey.c
index e8b63df5f975..17e29c6e878b 100644
--- a/drivers/usb/misc/chaoskey.c
+++ b/drivers/usb/misc/chaoskey.c
@@ -232,10 +232,10 @@ static void chaoskey_disconnect(struct usb_interface *interface)
if (dev->hwrng_registered)
hwrng_unregister(&dev->hwrng);

- mutex_lock(&chaoskey_list_lock);
usb_deregister_dev(interface, &chaoskey_class);

usb_set_intfdata(interface, NULL);
+ mutex_lock(&chaoskey_list_lock);
mutex_lock(&dev->lock);

dev->present = false;