Re: linux-next: Signed-off-by missing for commit in the mediatek tree

From: AngeloGioacchino Del Regno
Date: Wed Oct 09 2024 - 04:47:54 EST


Il 09/10/24 10:19, Hsin-Te Yuan ha scritto:
On Wed, Oct 9, 2024 at 3:52 PM AngeloGioacchino Del Regno <
angelogioacchino.delregno@xxxxxxxxxx> wrote:

Il 08/10/24 22:15, Stephen Rothwell ha scritto:
Hi all,

Commits

65b99309a9c1 ("arm64: dts: mt8183: Damu: add i2c2's
i2c-scl-internal-delay-ns")
025869564bf8 ("arm64: dts: mt8183: cozmo: add i2c2's
i2c-scl-internal-delay-ns")
3d3bc7cb46e8 ("arm64: dts: mt8183: burnet: add i2c2's
i2c-scl-internal-delay-ns")
5bbddfd0470f ("arm64: dts: mt8183: fennel: add i2c2's
i2c-scl-internal-delay-ns")
(The above also has an empty Reviewed-by tag)
ca80f75083f6 ("arm64: dts: mt8183: set DMIC one-wire mode on Damu")

are missing a Signed-off-by from their authors.


The empty R-b happened because b4 didn't interpret "<email>2" correctly
and dropped the email entirely. We should probably report that to the
authors.

Anyway, dropping these commits until Hsin-Te and Daolong clarify what to
do here
with the S-o-b tags, I didn't notice that the author was different, there.

Sorry about that.

Regards,
Angelo



There is a "Signed-off-by: Daolong Zhu <
jg_daolongzhu@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>" tag for i2c related
patches and a "Signed-off-by: Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx>" tag for
DMIC patch in downstream, but I accidentally dropped it while sending to
upstream.
Sorry about that. Should I resend these patches?

By the way, it seems that Daolong is no longer working for Mediatek, and I
don't have any way to contact Daolong.


Yes please resend the patches; make sure to keep the Reviewed-by tags, and
also make sure that *your* S-o-B (and the author's) is present on them.
If the author is Daolong, you either take authorship and add him with a
Co-Developed-by, or you ask him to signoff the patches.

Thanks,
Angelo