Re: [PATCH] arm64: dts: mediatek: mt8195: Fix dtbs_check error for tphy
From: Fei Shao
Date: Wed Oct 09 2024 - 06:56:32 EST
On Wed, Oct 9, 2024 at 4:50 PM Macpaul Lin <macpaul.lin@xxxxxxxxxxxx> wrote:
>
> On 10/8/24 15:10, Fei Shao wrote:
> >
> > External email : Please do not click links or open attachments until you
> > have verified the sender or the content.
> >
> > On Tue, Oct 8, 2024 at 1:36 PM Macpaul Lin <macpaul.lin@xxxxxxxxxxxx> wrote:
> >>
> >> The u3phy1 node in mt8195.dtsi was triggering a dtbs_check error.
> >> The error message was:
> >> t-phy@11e30000: 'power-domains' does not match any of the regexes:
> >> '^(usb|pcie|sata)-phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
> >> Fix this issue by dropping 'power-domains' of u3phy1 node.
> >>
> >> Fixes: 37f2582883be ("arm64: dts: Add mediatek SoC mt8195 and evaluation board")
> >> Signed-off-by: Macpaul Lin <macpaul.lin@xxxxxxxxxxxx>
> >> ---
> >
> > Apart from this, can you or Chunfeng confirm if we should make a
> > similar change for MT8188[1]?
> >
> > [1]: https://lore.kernel.org/all/20241004081218.55962-3-fshao@xxxxxxxxxxxx/
> >
> > Regards,
> > Fei
> >
>
> According to the suggestion and discussion in
>
> [1]:
> https://lore.kernel.org/lkml/20241008-disorder-slacking-d8196ceb68f7@spud/T/#mccf978d76f52cc26970f3f3be6120055e4698fe6
>
> I think adding 'power-domains' to PCIE node of MT8188 is okay.
>
Acked, thanks!
Fei