Re: [PATCH 2/2] serial: 8250_omap: mark the serial as on the wakeup path if no_console_suspend

[Thomas Richard]

On 10/9/24 12:50, Ulf Hansson wrote:
> On Tue, 8 Oct 2024 at 11:34, Thomas Richard <thomas.richard@xxxxxxxxxxx> wrote:
>>
>> If the console suspend is disabled, mark the serial as on the wakeup path
>> to keep its PM domain powered on.
>>
>> Suggested-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx>
>> Signed-off-by: Thomas Richard <thomas.richard@xxxxxxxxxxx>
>> ---
>>  drivers/tty/serial/8250/8250_omap.c | 8 ++++++--
>>  1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c
>> index 88b58f44e4e9..6764fe2f9cad 100644
>> --- a/drivers/tty/serial/8250/8250_omap.c
>> +++ b/drivers/tty/serial/8250/8250_omap.c
>> @@ -1660,8 +1660,12 @@ static int omap8250_suspend(struct device *dev)
>>         if (!device_may_wakeup(dev))
>>                 priv->wer = 0;
>>         serial_out(up, UART_OMAP_WER, priv->wer);
>> -       if (uart_console(&up->port) && console_suspend_enabled)
>> -               err = pm_runtime_force_suspend(dev);
>> +       if (uart_console(&up->port)) {
>> +               if (console_suspend_enabled)
>> +                       err = pm_runtime_force_suspend(dev);
>> +               else
>> +                       device_set_wakeup_path(dev);
>> +       }
> 
> Isn't this already managed by the serial core? See commit a47cf07f60dc
> ("serial: core: Call device_set_awake_path() for console port")

Yes you're right.
So this patch is useless.

Regards,

Thomas