Re: [PATCH] rust: query the compiler for dylib path

[Tamir Duberstein]

On Wed, Oct 9, 2024 at 8:43 AM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> On Wed, Oct 9, 2024 at 12:48 AM Tamir Duberstein <tamird@xxxxxxxxx> wrote:
> >
> > Rust proc-macro crates are loaded by the compiler at compile-time, so
> > are always dynamic libraries; on macOS, these artifacts get a .dylib
> > extension rather than .so.
>
> What is the status of the macOS build support? A link would be nice here.

What would you have me link to? With this patch applied and using
https://github.com/bee-headers/homebrew-bee-headers I was able to build a kernel
on my apple silicon mac. Relevant config:

tamird@Tamirs-MBP linux % rg -N '_RUST' .config
CONFIG_RUSTC_VERSION=108100
CONFIG_RUST_IS_AVAILABLE=y
CONFIG_RUST=y
CONFIG_RUSTC_VERSION_TEXT="rustc 1.81.0 (eeb90cda1 2024-09-04)"
CONFIG_RUSTC_SUPPORTS_ARM64=y
CONFIG_HAVE_RUST=y
# CONFIG_RUST_FW_LOADER_ABSTRACTIONS is not set
# CONFIG_BLK_DEV_RUST_NULL is not set
# CONFIG_RUST_PHYLIB_ABSTRACTIONS is not set
CONFIG_SAMPLES_RUST=y
CONFIG_SAMPLE_RUST_MINIMAL=m
CONFIG_SAMPLE_RUST_PRINT=m
CONFIG_SAMPLE_RUST_HOSTPROGS=y
CONFIG_RUST_DEBUG_ASSERTIONS=y
CONFIG_RUST_OVERFLOW_CHECKS=y
# CONFIG_RUST_BUILD_ASSERT_ALLOW is not set

> > Signed-off-by: Fiona Behrens <me@xxxxxxxxxx>
>
> Is this patch Fiona's/yours/both? Depending on that, different tags
> are needed here (including `From:`). Please see:
>
>     https://docs.kernel.org/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

Thanks. Fiona wrote the original patch ~2 years ago. I rebased it and
generalized it some. I'll use Co-developed-by.

> > @@ -9,6 +9,8 @@ import logging
> >  import os
> >  import pathlib
> >  import sys
> > +import os
> > +import subprocess
>
> Nit: double import, unsorted.

Ack, will fix.

>
> Thanks!
>
> Cheers,
> Miguel