Re: [PATCH v2 RESEND] function_graph: Support recording and printing the function return address

From: Donglin Peng
Date: Wed Oct 09 2024 - 10:03:22 EST


On Wed, Oct 9, 2024 at 9:37 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> On Wed, 9 Oct 2024 11:03:40 +0800
> Donglin Peng <dolinux.peng@xxxxxxxxx> wrote:
>
> > From: Donglin Peng <pengdonglin@xxxxxxxxxx>
> >
> > When using function_graph tracer to analyze the flow of kernel function
> > execution, it is often necessary to quickly locate the exact line of code
> > where the call occurs. While this may be easy at times, it can be more
> > time-consuming when some functions are inlined or the flow is too long.
> >
> > This feature aims to simplify the process by recording the return address
> > of traced funcions and printing it when outputing trace logs.
> >
> > To enhance human readability, the prefix 'ret=' is used for the kernel return
> > value, while '<-' serves as the prefix for the return address in trace logs to
> > make it look more like the function tracer.
> >
> > A new trace option named 'funcgraph-retaddr' has been introduced, and the
> > existing option 'sym-addr' can be used to control the format of the return
> > address.
> >
>
> Is there a reason for the resend? I already have it in my for-next branch.

I'm sorry and I did not notice it.

>
> -- Steve