Re: [PATCH] asm-generic: provide generic page_to_phys and phys_to_page implementations

From: Christophe Leroy
Date: Wed Oct 09 2024 - 10:38:14 EST




Le 09/10/2024 à 13:43, Christoph Hellwig a écrit :
page_to_phys is duplicated by all architectures, and from some strange
reason placed in <asm/io.h> where it doesn't fit at all.

phys_to_page is only provided by a few architectures despite having a lot
of open coded users.

Provide generic versions in <asm-generic/memory_model.h> to make these
helpers more easily usable.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>
---
arch/alpha/include/asm/io.h | 1 -
arch/arc/include/asm/io.h | 3 ---
arch/arm/include/asm/memory.h | 6 ------
arch/arm64/include/asm/memory.h | 6 ------
arch/csky/include/asm/page.h | 3 ---
arch/hexagon/include/asm/page.h | 6 ------
arch/loongarch/include/asm/page.h | 3 ---
arch/m68k/include/asm/virtconvert.h | 3 ---
arch/microblaze/include/asm/page.h | 1 -
arch/mips/include/asm/io.h | 5 -----
arch/nios2/include/asm/io.h | 3 ---
arch/openrisc/include/asm/page.h | 2 --
arch/parisc/include/asm/page.h | 1 -
arch/powerpc/include/asm/io.h | 12 ------------

As far as I understand, this patch silently drops part of commit 6bf752daca07 ("powerpc: implement CONFIG_DEBUG_VIRTUAL").

Can you please clarify ?

Christophe