Re: [PATCH v4 03/11] OPP: Rework _set_required_devs() to manage a single device per call

[Ulf Hansson]

On Wed, 9 Oct 2024 at 17:48, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
>
> On 09-10-24, 15:55, Ulf Hansson wrote:
> > On Thu, 3 Oct 2024 at 09:14, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> > >
> > > On 02-10-24, 14:22, Ulf Hansson wrote:
> > > >  /**
> > > >   * struct opp_config_data - data for set config operations
> > > >   * @opp_table: OPP table
> > > >   * @flags: OPP config flags
> > > > + * @index: The position in the array of required_devs
> > > >   *
> > > >   * This structure stores the OPP config information for each OPP table
> > > >   * configuration by the callers.
> > > > @@ -48,6 +49,7 @@ extern struct list_head opp_tables;
> > > >  struct opp_config_data {
> > > >       struct opp_table *opp_table;
> > > >       unsigned int flags;
> > > > +     unsigned int index;
> > >
> > > Maybe name this required_dev_index as well ?
> >
> > Sure!
> >
> > Did you manage to get some time to look at the other patches in the series yet?
>
> Ahh, they looked okay and most of them were already Acked by me I guess :)

Right, it was mostly patch 3 and patch4 that I would appreciate an
ack/reviewed-by tag from you.

If I make the rename to "required_dev_index" according to your
suggestion above, it sounds like I could add the acks from you?

>
> Sorry for the confusion.

No worries!

Kind regards
Uffe