Re: [PATCH] rust: remove unnecessary #includes
From: Miguel Ojeda
Date: Wed Oct 09 2024 - 12:18:16 EST
On Wed, Oct 9, 2024 at 5:37 PM Dirk Behme <dirk.behme@xxxxxxxxx> wrote:
>
> * Theoretically the grammer fix in exports.c could go into an
> independent patch. But if not it at least should be mentioned in the
> commit message. Let Miguel decide if he wants an extra patch or not ;)
Indeed, in general, one should not have unstated/unrelated changes.
> * Maybe a
>
> Fixes: e26fa546042a ("rust: kbuild: auto generate helper exports")
>
> tag could be added? Even though Miguel might route it through
> rust-next as its not urgent for routing through rust-fixes.
I think this is a cleanup, i.e. just unnecessary `#include`s being
present, right? In other words, there is no "bug" apart from not being
optimal (one could see cleanups as things that should have been done,
but I guess we should draw the line somewhere).
Andreas: was there a reason to keep those `#include`s, just in case?
Thanks!
Cheers,
Miguel