Re: [PATCH v2 1/2] mfd: bd96801: Add ERRB IRQ
From: Lee Jones
Date: Wed Oct 09 2024 - 12:23:57 EST
On Thu, 03 Oct 2024, Matti Vaittinen wrote:
> The ROHM BD96801 "scalable PMIC" provides two physical IRQs. The ERRB
> handling can in many cases be omitted because it is used to inform fatal
> IRQs, which usually kill the power from the SOC.
>
> There may however be use-cases where the SOC has a 'back-up' emergency
> power source which allows some very short time of operation to try to
> gracefully shut down sensitive hardware. Furthermore, it is possible the
> processor controlling the PMIC is not powered by the PMIC. In such cases
> handling the ERRB IRQs may be beneficial.
>
> Add support for ERRB IRQs.
>
> Signed-off-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
> ---
> Revision history:
> New series (only ERRB addition)
> v2:
> - Suffle local variables in probe()
> - Unify and improve the error prints when adding regmap IRQ chip for
> INTB or ERRB fails.
> v1:
> - use devm allocation for regulator_res
> - use goto skip_errb instead of an if (errb)
> - constify immutable structs
>
> Old series (All BD96801 functionality + irqdomain and regmap changes)
> v2 => v3:
> - No changes
> v1 => v2:
> - New patch
> ---
> drivers/mfd/rohm-bd96801.c | 275 ++++++++++++++++++++++++++++++++-----
> 1 file changed, 241 insertions(+), 34 deletions(-)
Are the 2 patches tied together or can they be taken separately?
--
Lee Jones [李琼斯]