Re: [PATCH v2 RESEND] function_graph: Support recording and printing the function return address

From: Steven Rostedt
Date: Wed Oct 09 2024 - 13:19:49 EST


On Thu, 10 Oct 2024 01:32:22 +0900
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx> wrote:

> >From 8c2851452dd11a3a20ab22bd6bf8dd663c3c4b9c Mon Sep 17 00:00:00 2001
> From: "Masami Hiramatsu (Google)" <mhiramat@xxxxxxxxxx>
> Date: Thu, 10 Oct 2024 00:58:12 +0900
> Subject: [PATCH] tracing/fgraph: Simplify return address printing in function
> graph tracer
>
> Simplify return address printing in the function graph tracer by removing
> fgraph_extras. Since this feature is only used by the function graph
> tracer and we can check the flag directly in the function graph tracer,
> we can remove the fgraph_extras from the fgraph callback.
>
> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
> ---
> include/linux/ftrace.h | 16 ++++------
> kernel/trace/fgraph.c | 45 ++++++++++++++++++----------
> kernel/trace/ftrace.c | 3 +-
> kernel/trace/trace.h | 3 +-
> kernel/trace/trace_functions_graph.c | 14 ++++-----
> kernel/trace/trace_irqsoff.c | 3 +-
> kernel/trace/trace_sched_wakeup.c | 3 +-
> kernel/trace/trace_selftest.c | 8 ++---
> 8 files changed, 48 insertions(+), 47 deletions(-)
>

Hi Masami,

Care to send this as a real patch?

-- Steve