Re: [PATCH 1/1] selftests/rseq: Fix mm_cid test failure

[Shuah Khan]

On 10/8/24 19:28, Mathieu Desnoyers wrote:
> Adapt the rseq.c/rseq.h code to follow GNU C library changes introduced by:
>
> glibc commit 2e456ccf0c34 ("Linux: Make __rseq_size useful for feature detection (bug 31965)")
>
> Without this fix, rseq selftests for mm_cid fail:
>
> ./run_param_test.sh
> Default parameters
> Running test spinlock
> Running compare-twice test spinlock
> Running mm_cid test spinlock
> Error: cpu id getter unavailable
>
> [ This is based on the following branch:
>    https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git
>    branch: fixes ]

Did you forget version prefix? It get confusing without
it. Pleas eremeber to add prefix and version information.

> Fixes: 18c2355838e7 ("selftests/rseq: Implement rseq mm_cid field support")
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> CC: Boqun Feng <boqun.feng@xxxxxxxxx>
> CC: "Paul E. McKenney" <paulmck@xxxxxxxxxx>
> Cc: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
> CC: Carlos O'Donell <carlos@xxxxxxxxxx>
> CC: Florian Weimer <fweimer@xxxxxxxxxx>
> CC: linux-kselftest@xxxxxxxxxxxxxxx
> CC: stable@xxxxxxxxxxxxxxx
> ---

Applied to linux-kselftest fixes for next rc.

Did you forget version prefix? It was a bit confuing
>   tools/testing/selftests/rseq/rseq.c | 110 +++++++++++++++++++---------
>   tools/testing/selftests/rseq/rseq.h |  10 +--
>   2 files changed, 77 insertions(+), 43 deletions(-)

thanks,
-- Shuah