Re: [PATCH v2] XArray: minor documentation improvements
From: Randy Dunlap
Date: Wed Oct 09 2024 - 18:22:18 EST
On 10/9/24 1:52 PM, Tamir Duberstein wrote:
> - Replace "they" with "you" where "you" is used in the preceding
> sentence fragment.
> - Use "erasing" rather than "storing `NULL`" when describing multi-index
> entries. Split this into a separate sentence.
> - Add "call" parentheses on "xa_store" for consistency and
> linkification.
>
> Signed-off-by: Tamir Duberstein <tamird@xxxxxxxxx>
> ---
> V1 -> V2: s/use/you/ (Darrick J. Wong)
>
> Documentation/core-api/xarray.rst | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/core-api/xarray.rst b/Documentation/core-api/xarray.rst
> index 77e0ece2b1d6..75c83b37e88f 100644
> --- a/Documentation/core-api/xarray.rst
> +++ b/Documentation/core-api/xarray.rst
> @@ -52,8 +52,8 @@ An unusual feature of the XArray is the ability to create entries which
> occupy a range of indices. Once stored to, looking up any index in
> the range will return the same entry as looking up any other index in
> the range. Storing to any index will store to all of them. Multi-index
> -entries can be explicitly split into smaller entries, or storing ``NULL``
Is storing %NULL does by making a function call or just by doing
*xa1 = NULL;
?
> -into any entry will cause the XArray to forget about the range.
> +entries can be explicitly split into smaller entries. Erasing any entry
> +will cause the XArray to forget about the range.
Clearing any entry by calling xa_erase() will cause the XArray to forget about the range.
>
> Normal API
> ==========
--
~Randy