RE: [PATCH net-next 01/11] dt-bindings: net: add compatible string for i.MX95 EMDIO

[Wei Fang]

> -----Original Message-----
> From: Frank Li <frank.li@xxxxxxx>
> Sent: 2024年10月10日 0:27
> To: Wei Fang <wei.fang@xxxxxxx>
> Cc: davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx;
> pabeni@xxxxxxxxxx; robh@xxxxxxxxxx; krzk+dt@xxxxxxxxxx;
> conor+dt@xxxxxxxxxx; Vladimir Oltean <vladimir.oltean@xxxxxxx>; Claudiu
> Manoil <claudiu.manoil@xxxxxxx>; Clark Wang <xiaoning.wang@xxxxxxx>;
> christophe.leroy@xxxxxxxxxx; linux@xxxxxxxxxxxxxxx; bhelgaas@xxxxxxxxxx;
> imx@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH net-next 01/11] dt-bindings: net: add compatible string for
> i.MX95 EMDIO
> 
> On Wed, Oct 09, 2024 at 05:51:06PM +0800, Wei Fang wrote:
> > The EMDIO of i.MX95 has been upgraded to revision 4.1, and the vendor
> > ID and device ID have also changed, so add the new compatible strings
> > for i.MX95 EMDIO.
> >
> > Signed-off-by: Wei Fang <wei.fang@xxxxxxx>
> > ---
> >  .../devicetree/bindings/net/fsl,enetc-mdio.yaml   | 15 +++++++++++----
> >  1 file changed, 11 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml
> > b/Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml
> > index c1dd6aa04321..71f1e32b00dc 100644
> > --- a/Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml
> > +++ b/Documentation/devicetree/bindings/net/fsl,enetc-mdio.yaml
> > @@ -20,10 +20,17 @@ maintainers:
> >
> >  properties:
> >    compatible:
> > -    items:
> > -      - enum:
> > -          - pci1957,ee01
> > -      - const: fsl,enetc-mdio
> > +    oneOf:
> > +      - items:
> > +          - enum:
> > +              - pci1957,ee01
> > +          - const: fsl,enetc-mdio
> > +      - items:
> > +          - const: pci1131,ee00
> > +      - items:
> > +          - enum:
> > +              - nxp,netc-emdio
> > +          - const: pci1131,ee00
> 
> why reverse order here. suggested:

Hi Frank,

The Vendor ID and Device ID of the following NETC IP will not change
for a long time in the future, but it will be used on different platforms.
It is not certain whether special processing is required on different
platforms, so the enum type is added for subsequent expansion.
>

> oneOf:
>   - items:
>       - enum:
>           - pci1957,ee01
>           - pci1131,ee00
>       - const: fsl,enetc-mdio
>   - items:
>       - const: pci1131,ee00
> 
> Frank
> >
> >    reg:
> >      maxItems: 1
> > --
> > 2.34.1
> >