Re: linux-next: build failure after merge of the ftrace tree

[Donglin Peng]

On Thu, Oct 10, 2024 at 10:46 AM Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
>
> Hi all,
>
> After merging the ftrace tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> kernel/trace/trace_functions_graph.c: In function '__trace_graph_retaddr_entry':
> kernel/trace/trace_functions_graph.c:151:14: error: implicit declaration of function 'call_filter_check_discard' [-Wimplicit-function-declaration]
>   151 |         if (!call_filter_check_discard(call, entry, buffer, event))
>       |              ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> Caused by commit
>
>   21e92806d39c ("function_graph: Support recording and printing the function return address")
>
> interacting with commit
>
>   49e4154f4b16 ("tracing: Remove TRACE_EVENT_FL_FILTERED logic")
>
> I have used the ftrace tree from next-20241009 for today.
>

The function call_filter_check_discard was removed in commit
49e4154f4b16 ("tracing: Remove TRACE_EVENT_FL_FILTERED logic"),
but the function __trace_graph_retaddr_entry still invoke it. I will
submit a patch to address this issue.

> --
> Cheers,
> Stephen Rothwell