Re: [PATCH v6 2/4] drm/amd/display: Add support for minimum backlight quirk

[Thomas Weißschuh]

On 2024-09-16 15:43:35-0400, Harry Wentland wrote:
> On 2024-08-26 12:57, Mario Limonciello wrote:
> > On 8/24/2024 13:33, Thomas Weißschuh wrote:
> >> Not all platforms provide the full range of PWM backlight capabilities
> >> supported by the hardware through ATIF.
> >> Use the generic drm panel minimum backlight quirk infrastructure to
> >> override the capabilities where necessary.
> >>
> >> Testing the backlight quirk together with the "panel_power_savings"
> >> sysfs file has not shown any negative impact.
> >> One quirk seems to be that 0% at panel_power_savings=0 seems to be
> >> slightly darker than at panel_power_savings=4.
> > 
> > Thanks; This is the kind of thing I was worried about.
> > 
> > Harry, Leo,
> > 
> > Is that expected?  I wonder if we need to internally turn off panel
> > power savings in display code when brightness falls a threshold (12
> > IIRC was the real "minimum" advertised in the table?).
> 
> How much darker? Is it bothersome?

Was this questions for meant for me?
To me personally it's absolutely not bothersome.
I probably wouldn't have noticed it if not explicitly looking for it.

> I wonder the FW and driver have different min backlight values now.
> 
> Leo, any thoughts?

Friendly ping.