Re: [PATCH v5 4/8] module: prepare to handle ROX allocations for text

[Mike Rapoport]

On Wed, Oct 09, 2024 at 03:23:40PM -0700, Song Liu wrote:
> On Wed, Oct 9, 2024 at 11:10 AM Mike Rapoport <rppt@xxxxxxxxxx> wrote:
> [...]
> > diff --git a/include/linux/module.h b/include/linux/module.h
> > index 88ecc5e9f523..7039f609c6ef 100644
> > --- a/include/linux/module.h
> > +++ b/include/linux/module.h
> > @@ -367,6 +367,8 @@ enum mod_mem_type {
> >
> >  struct module_memory {
> >         void *base;
> > +       void *rw_copy;
> > +       bool is_rox;
> >         unsigned int size;
> 
> Do we really need to hold the rw_copy all the time? 

We hold it only during module initialization, it's freed in
post_relocation.

> Thanks,
> Song
> 
> [...]

-- 
Sincerely yours,
Mike.