Re: [PATCH v2] xfs: Check for deallayed allocations before setting extsize
From: Christoph Hellwig
Date: Thu Oct 10 2024 - 02:50:33 EST
s/deallayed/delayed/
>
> +static inline bool xfs_inode_has_data(struct xfs_inode *ip)
> +{
> + return (ip->i_df.if_nextents > 0 || ip->i_delayed_blks > 0);
Nit: no need for the braces.
> + if (S_ISREG(VFS_I(ip)->i_mode) &&
> + xfs_inode_has_data(ip) &&
This can now be condensed to:
if (S_ISREG(VFS_I(ip)->i_mode) && xfs_inode_has_data(ip) &&
Otherwise this still looks good to me.