Re: [PATCH v5 6/8] x86/module: perpare module loading for ROX allocations of text

From: Christoph Hellwig
Date: Thu Oct 10 2024 - 02:57:33 EST


> +extern void apply_alternatives(struct alt_instr *start, struct alt_instr *end,
> + struct module *mod);
> +extern void apply_retpolines(s32 *start, s32 *end, struct module *mod);
> +extern void apply_returns(s32 *start, s32 *end, struct module *mod);
> +extern void apply_seal_endbr(s32 *start, s32 *end, struct module *mod);
> extern void apply_fineibt(s32 *start_retpoline, s32 *end_retpoine,
> - s32 *start_cfi, s32 *end_cfi);
> -
> -struct module;
> + s32 *start_cfi, s32 *end_cfi, struct module *mod);

Please drop all the pointless externs while you're at it.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>