RE: [PATCH 3/3] arm64: dts: exynosautov920: add watchdog DT node

[김태완]

Hi,

I will move it between 'chipid@10000000' and 'interrupt-controller@10400000'.
Thank you for pointing.

Best regards,
Taewan Kim.

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: Monday, September 30, 2024 8:38 PM
> To: Taewan Kim <trunixs.kim@xxxxxxxxxxx>; Wim Van Sebroeck <wim@linux-
> watchdog.org>; Guenter Roeck <linux@xxxxxxxxxxxx>; Rob Herring
> <robh@xxxxxxxxxx>; Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley
> <conor+dt@xxxxxxxxxx>; Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
> Cc: linux-watchdog@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> samsung-soc@xxxxxxxxxxxxxxx; Byoungtae Cho <bt.cho@xxxxxxxxxxx>
> Subject: Re: [PATCH 3/3] arm64: dts: exynosautov920: add watchdog DT node
> 
> On 13/09/2024 10:03, Taewan Kim wrote:
> > From: Byoungtae Cho <bt.cho@xxxxxxxxxxx>
> >
> > Adds two watchdog devices for ExynosAutoV920 SoC.
> >
> > Signed-off-by: Byoungtae Cho <bt.cho@xxxxxxxxxxx>
> > Signed-off-by: Taewan Kim <trunixs.kim@xxxxxxxxxxx>
> > ---
> >  .../arm64/boot/dts/exynos/exynosautov920.dtsi | 20
> > +++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> > b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> > index c1c8566d74f5..de210f8e5599 100644
> > --- a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> > +++ b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> > @@ -297,6 +297,26 @@ pinctrl_aud: pinctrl@1a460000 {
> >  			compatible = "samsung,exynosautov920-pinctrl";
> >  			reg = <0x1a460000 0x10000>;
> >  		};
> > +
> > +		watchdog_cl0: watchdog@10060000 {
> 
> Does not look like placed in correct location. 1a46 > 1006. Please follow
> DTS coding style in all your works.
> 
> Best regards,
> Krzysztof