Re: [PATCH 1/3] arm64: dts: qcom: x1e80100: Add QUP power domains and OPPs

From: Johan Hovold
Date: Thu Oct 10 2024 - 05:30:13 EST


On Mon, Oct 07, 2024 at 08:22:25PM +0200, Stephan Gerhold wrote:
> Add the power domains and OPP tables to all the QUP-related UART/I2C/SPI
> nodes to ensure that we vote for the necessary performance states. Similar
> to sm8350.dtsi, the OPPs depend on the QUP instance. The first two
> instances in each geniqup group need &rpmhpd_opp_svs starting at 120MHz,
> the others already starting at 100MHz. I2C always runs at a lower clock
> frequency and therefore uses a fixed vote.
>
> Signed-off-by: Stephan Gerhold <stephan.gerhold@xxxxxxxxxx>

Looks good to me.

Reviewed-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
Tested-by: Johan Hovold <johan+linaro@xxxxxxxxxx>

Johan