Re: [PATCH net-next] tipc: Return -EINVAL on error from addr2str() methods

From: Paolo Abeni
Date: Thu Oct 10 2024 - 05:40:23 EST


On 10/8/24 16:24, Shigeru Yoshida wrote:
The return value 1 on error of the addr2str() methods are not
descriptive. Return -EINVAL instead.

Signed-off-by: Shigeru Yoshida <syoshida@xxxxxxxxxx>

I'm sorry if I gave conflicting advice in the past, but I now think this patch falls under the 'small cleanup patches' category we are actively discouraging outside the scope of a wider (functional) change:

https://lore.kernel.org/netdev/20241009-doc-mc-clean-v2-1-e637b665fa81@xxxxxxxxxx/

Thanks,

Paolo