Re: [PATCH net v3 1/4] ip6mr: Lock RCU before ip6mr_get_table() call in ip6mr_vif_seq_start()

From: Eric Dumazet
Date: Thu Oct 10 2024 - 05:44:30 EST


On Thu, Oct 10, 2024 at 11:11 AM Stefan Wiehler
<stefan.wiehler@xxxxxxxxx> wrote:
>
> When IPV6_MROUTE_MULTIPLE_TABLES is enabled, calls to ip6mr_get_table()
> must be done under RCU or RTNL lock.

Could you add in the changelog that ip6mr_vif_seq_stop() would be called
in the (currently not possible) case ip6mr_vif_seq_start() returns an error ?

>
> Signed-off-by: Stefan Wiehler <stefan.wiehler@xxxxxxxxx>
> Fixes: d1db275dd3f6 ("ipv6: ip6mr: support multiple tables")

Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>

Thanks.