Re: [PATCH 4/5] arm64: dts: qcom: move common parts for qcs8300-ride variants into a .dtsi

[Yijie Yang]

On 2024-10-10 14:18, Krzysztof Kozlowski wrote:
> On Thu, Oct 10, 2024 at 10:57:18AM +0800, Yijie Yang wrote:
> > In order to support multiple revisions of the qcs8300-ride board, create
> > a .dtsi containing the common parts and split out the ethernet bits into
> > the actual board file as they will change in revision 2.
> >
> > Signed-off-by: Yijie Yang <quic_yijiyang@xxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/qcs8300-ride.dts  | 373 +----------------------------
> >   arch/arm64/boot/dts/qcom/qcs8300-ride.dtsi | 364 ++++++++++++++++++++++++++++
>
> This is tricky to review. Use proper -M/-B/-C arguments for
> format-patch, so the rename will be detected.
>
> You basically renamed entire file!

Sure, I'll handle the optimization of that.

> Best regards,
> Krzysztof