RE: [PATCH v2 0/2] clk: imx93: Move IMX93_CLK_END macro to clk driver

[Peng Fan]

> Subject: Re: [PATCH v2 0/2] clk: imx93: Move IMX93_CLK_END macro
> to clk driver
> 
> On Fri, Sep 20, 2024 at 05:04:19PM -0700, Pengfei Li wrote:
> > On Thu, Aug 29, 2024 at 10:07:05AM +0300, Abel Vesa wrote:
> > > On 24-06-27 16:24:24, Pengfei Li wrote:
> > > > 'IMX93_CLK_END' macro was previously defined in imx93-clock.h
> to
> > > > indicate the number of clocks, but it is not part of the ABI, so
> > > > it should be moved to clk driver.
> > > >
> > >
> > > Right, why?
> > >
> > > All other providers have been using the _CLK_END from the
> bindings
> > > header. What is so special about this ? AFAICT, nothing.
> > >
> > > > ---
> > > > Change for v2:
> > > > - Use pre-processor define to simplify code.
> > > > - link to v1:
> > > > https://lore.kernel.org/all/20240625175147.94985-1-
> pengfei.li_1@nx
> > > > p.com/
> > > >
> > > > Pengfei Li (2):
> > > >   clk: imx93: Move IMX93_CLK_END macro to clk driver
> > > >   dt-bindings: clock: imx93: Drop IMX93_CLK_END macro
> definition
> > > >
> > > >  drivers/clk/imx/clk-imx93.c             | 2 ++
> > > >  include/dt-bindings/clock/imx93-clock.h | 1 -
> > > >  2 files changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > --
> > > > 2.34.1
> > > >
> > >
> >
> > Hi Abel,
> >
> > This is a modification based on previous comments:
> > https://lore.kernel.org/all/20240604150447.GA604729-
> robh@xxxxxxxxxx/
> > Actually, whether this _CLK_END macro change is added or not, both
> is ok for me.
> > I just want to add some new clocks to bindings header.
> >
> > BR,
> > Pengfei Li
> >
> 
> Hi Abel, you are the maintainer of clk-imx93.c, so if this patchset is ok,
> could you help apply it. and then I will send subsequent patchset to
> add some new clocks.

There is no good way here. I think you v1 patch is fine:
https://lore.kernel.org/all/20240625175147.94985-2-pengfei.li_1@xxxxxxx/

Moving END to driver indeed is a bit weird.

Abel,

When you have time, please give a look at upper v1.
I not find a better way to drop _END from bindings.

Thanks,
Peng.

> 
> BR,
> Pengfei Li