[PATCH RFC 12/28] ARM: entry: Rename syscall invocation

From: Linus Walleij
Date: Thu Oct 10 2024 - 07:35:49 EST


Now that we do not have a separate trace syscall invocation
path, rename the invocation functions to be generic.

This can be squashed into the previous patch, it is just done
here for the previous patch to be easier to get a cleaner
diff and be easier to read.

Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
---
arch/arm/include/asm/syscall.h | 2 +-
arch/arm/kernel/entry-common.S | 10 +++++-----
arch/arm/kernel/syscall.c | 6 +++---
3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/arch/arm/include/asm/syscall.h b/arch/arm/include/asm/syscall.h
index 9c664d8c5718..b94fd7ce17f8 100644
--- a/arch/arm/include/asm/syscall.h
+++ b/arch/arm/include/asm/syscall.h
@@ -19,7 +19,7 @@

extern const unsigned long sys_call_table[];

-int invoke_syscall_trace(void *table, struct pt_regs *regs, int scno);
+int invoke_syscall(void *table, struct pt_regs *regs, int scno);

static inline int syscall_get_nr(struct task_struct *task,
struct pt_regs *regs)
diff --git a/arch/arm/kernel/entry-common.S b/arch/arm/kernel/entry-common.S
index f0f1f8723965..f1e48002bd30 100644
--- a/arch/arm/kernel/entry-common.S
+++ b/arch/arm/kernel/entry-common.S
@@ -260,7 +260,7 @@ ENTRY(vector_swi)
stmdb sp!, {r4, r5} @ push fifth and sixth args
mov r0, tbl
mov r2, scno @ syscall number from r7
- bl invoke_syscall_trace
+ bl invoke_syscall
cmp r0, #0
beq ret_fast_syscall
/* This path taken when tracing */
@@ -390,7 +390,7 @@ ENDPROC(sys_mmap2)
* r1: regs
* r2: syscall number
*/
-SYM_TYPED_FUNC_START(invoke_syscall_trace_asm)
+SYM_TYPED_FUNC_START(invoke_syscall_asm)
#ifdef CONFIG_CPU_SPECTRE
csdb
#endif
@@ -400,17 +400,17 @@ SYM_TYPED_FUNC_START(invoke_syscall_trace_asm)
/* Make space to copy the two syscall stack arguments */
sub sp, sp, #S_OFF
mov scno, r2
- badr lr, __invoke_syscall_trace_ret @ return right here
+ badr lr, __invoke_syscall_ret @ return right here
ldmia r1, {r0 - r6} @ reload r0-r6 from regs
stmia sp, {r4, r5} @ copy stack arguments
ldr pc, [tbl, scno, lsl #2] @ call sys_* routine
-__invoke_syscall_trace_ret:
+__invoke_syscall_ret:
/* Drop the copied stack arguments */
add sp, sp, #S_OFF
pop {r4 - r10, lr}
ARM( mov pc, lr )
THUMB( bx lr )
-SYM_FUNC_END(invoke_syscall_trace_asm)
+SYM_FUNC_END(invoke_syscall_asm)

#ifdef CONFIG_OABI_COMPAT

diff --git a/arch/arm/kernel/syscall.c b/arch/arm/kernel/syscall.c
index ab9e66da0a80..968cec945a7e 100644
--- a/arch/arm/kernel/syscall.c
+++ b/arch/arm/kernel/syscall.c
@@ -8,9 +8,9 @@ static inline bool has_syscall_work(unsigned long flags)
return unlikely(flags & _TIF_SYSCALL_WORK);
}

-int invoke_syscall_trace_asm(void *table, struct pt_regs *regs, int scno);
+int invoke_syscall_asm(void *table, struct pt_regs *regs, int scno);

-__visible int invoke_syscall_trace(void *table, struct pt_regs *regs, int scno)
+__visible int invoke_syscall(void *table, struct pt_regs *regs, int scno)
{
unsigned long flags = read_thread_flags();
int ret;
@@ -22,7 +22,7 @@ __visible int invoke_syscall_trace(void *table, struct pt_regs *regs, int scno)
}

if (scno < NR_syscalls) {
- ret = invoke_syscall_trace_asm(table, regs, scno);
+ ret = invoke_syscall_asm(table, regs, scno);
goto exit_save;
}


--
2.46.2