Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h

[Vincenzo Frascino]

On 09/10/2024 10:53, Thomas Gleixner wrote:
> On Thu, Oct 03 2024 at 16:29, Vincenzo Frascino wrote:
>> The VDSO implementation includes headers from outside of the
>> vdso/ namespace.
>>
>> Introduce vdso/page.h to make sure that the generic library
>> uses only the allowed namespace.
>>
>> Note: on a 32-bit architecture UL is an unsigned 32 bit long. Hence when
>> it supports 64-bit phys_addr_t we might end up in situation in which
>> the
> 
> We end up with nothing.
> 
>> top 32 bit are cleared. To prevent this issue this patch provides
>> separate macros for PAGE_MASK.
> 
> 'this patch' is redundant information.
> 
> git grep 'This patch' Documentation/process/
> 

My bad, I thought that Documentation/process/submitting-patches.rst referred
only to the proposed change which is in imperative mood.

I will rephrase it accordingly.

...

>> +#define PAGE_MASK	(~(PAGE_SIZE-1))
> 
> #define PAGE_MASK	(~(PAGE_SIZE - 1))
> 
> please.
>

Will change it in v4.

> Thanks,
> 
>         tglx

-- 
Regards,
Vincenzo