Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h

[Vincenzo Frascino]

On 10/10/2024 00:58, Michael Ellerman wrote:
> Thomas Gleixner <tglx@xxxxxxxxxxxxx> writes:
>> On Wed, Oct 09 2024 at 11:53, Thomas Gleixner wrote:
>>> On Thu, Oct 03 2024 at 16:29, Vincenzo Frascino wrote:
>>
>> Hit send too early.
>>
>>>> +#if defined(CONFIG_PHYS_ADDR_T_64BIT)
>>>> +#define PAGE_MASK	(~((1 << CONFIG_PAGE_SHIFT) - 1))
>>
>> This really wants a comment. The magic reliance on integer sign
>> expansion is any thing than obvious.
> 
> +1
> 
> Vincenzo feel free to take/modify the one from arch/powerpc/include/asm/page.h :)
> 

I will, thank you :)

> cheers

-- 
Regards,
Vincenzo