Re: [PATCH v5 02/10] iio: dac: adi-axi-dac: update register names

From: Nuno Sá
Date: Thu Oct 10 2024 - 08:55:17 EST


On Tue, 2024-10-08 at 17:43 +0200, Angelo Dureghello wrote:
> From: Angelo Dureghello <adureghello@xxxxxxxxxxxx>
>
> Non functional, readability change.
>
> Update register names so that register bitfields can be more easily
> linked to the register name.
>
> Signed-off-by: Angelo Dureghello <adureghello@xxxxxxxxxxxx>
> ---

I don't fully agree that this is so much better that's worth the churn...

>From a quick a look I saw (I think) some defines where _REG seems to be missing.
Those is fine to change for consistency but I don't really seeing the big
benefit in changing them all.

(Sorry for only complaining in v5 about this...)

- Nuno Sá