Re: [PATCH] clocksource: Remove unused clocksource_change_rating

[Dr. David Alan Gilbert]

* Dr. David Alan Gilbert (linux@xxxxxxxxxxx) wrote:
> * John Stultz (jstultz@xxxxxxxxxx) wrote:
> > On Tue, Oct 8, 2024 at 5:30 PM <linux@xxxxxxxxxxx> wrote:
> > >
> > > From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
> > >
> > > clocksource_change_rating() has been unused since 2017's commit
> > > 63ed4e0c67df ("Drivers: hv: vmbus: Consolidate all Hyper-V specific clocksource code")
> > >
> > > Remove it.
> > >
> > > Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>
> > 
> > Thanks for submitting this cleanup!
> > 
> > Untested, but
> > Acked-by: John Stultz <jstultz@xxxxxxxxxx>
> 
> Hmm the test robot got an unused warning on __clocksource_change_rating
> I think that's because it's an allnoconfig and that needs moving inside
> the ifdef.
> 
> I'll look at it.

v2 posted 20241010135446.213098-1-linux@xxxxxxxxxxx
I shuffled the __clocksource_change_rating inside the ifdef (I guess
I could have inlined it instead).

The failure the testbot found only happens on a non-x86 allnoconfig.

Dave

> 
> Dave
> > thanks
> > -john
> > 
> -- 
>  -----Open up your eyes, open up your mind, open up your code -------   
> / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
> \        dave @ treblig.org |                               | In Hex /
>  \ _________________________|_____ http://www.treblig.org   |_______/
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/