Re: [PATCH v2 0/2] Add support for Zyxel EX3510-B

[Rob Herring (Arm)]

On Wed, 09 Oct 2024 14:54:52 -0700, Sam Edwards wrote:
> Hello BCMBCA maintainers,
> 
> This is a second, very minor revision of my previous series for introducing
> support for the Zyxel EX3510-B "series," largely motivated by my earlier
> patchset [1] that resolves validation errors in the BCMBCA DTs. If checking the
> DT, please apply that other patchset first. These changes do not depend on the
> other patchset to build correctly or apply cleanly; only to pass validation.
> 
> Happy spooky month,
> Sam
> 
> [1]: https://lore.kernel.org/linux-devicetree/20241009215046.1449389-1-CFSworks@xxxxxxxxx/T/
> 
> Changes v1->v2:
> - Rolled-in commit tags from previous version
> - Stylistic change to memory: s/0/0x0
> - Delete `range` property from the `nvmem-cells` node, in order to pass DT
>   checks.
> 
> COMMITTER NOTE: Email being what it is, the capitalization of my email address
> is apparently getting discarded. If it is important that the author email
> address have identical capitalization to the Signed-off-by, please explain why
> so I can investigate why this is happening and/or get these patches to you in a
> desired format.
> 
> Sam Edwards (2):
>   dt-bindings: arm64: bcmbca: Add Zyxel EX3510-B based on BCM4906
>   arm64: dts: broadcom: bcmbca: bcm4908: Add DT for Zyxel EX3510-B
> 
>  .../bindings/arm/bcm/brcm,bcmbca.yaml         |   1 +
>  arch/arm64/boot/dts/broadcom/bcmbca/Makefile  |   1 +
>  .../broadcom/bcmbca/bcm4906-zyxel-ex3510b.dts | 196 ++++++++++++++++++
>  3 files changed, 198 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dts
> 
> --
> 2.44.2
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb' for 20241009215454.1449508-1-CFSworks@xxxxxxxxx:

arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand-controller@1800: nand@0:partitions: 'oneOf' conditional failed, one must be fixed:
	'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: 'pinctrl-[0-9]+'
	'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: '^partition-[0-9a-z]+$', 'pinctrl-[0-9]+'
	'fis-index-block' is a required property
	'partitions-table-offset' is a required property
	'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: '^partition-.*$', 'pinctrl-[0-9]+'
	False schema does not allow 1
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand-controller@1800: nand@0:partitions:compatible: 'oneOf' conditional failed, one must be fixed:
		['brcm,bcm4908-partitions'] is too short
		'fixed-partitions' was expected
		'sercomm,sc-partitions' was expected
	'arm,arm-firmware-suite' was expected
	'brcm,bcm947xx-cfe-partitions' was expected
	'linksys,ns-partitions' was expected
	'qcom,smem-part' was expected
	'redboot-fis' was expected
	'tplink,safeloader-partitions' was expected
	Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'compatible', 'mac@106a0' were unexpected)
	['nvmem-cells'] is too short
	'brcm,bcm4908-firmware' was expected
	'linksys,ns-firmware' was expected
	Unevaluated properties are not allowed ('compatible' was unexpected)
	['brcm,bcm4908-firmware'] is too short
	from schema $id: http://devicetree.org/schemas/mtd/brcm,brcmnand.yaml#
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand-controller@1800: nand@0: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'nand-ecc-strength', 'partitions' were unexpected)
	from schema $id: http://devicetree.org/schemas/mtd/brcm,brcmnand.yaml#
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand-controller@1800: nand@0:partitions: 'oneOf' conditional failed, one must be fixed:
	'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: 'pinctrl-[0-9]+'
	'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: '^partition-[0-9a-z]+$', 'pinctrl-[0-9]+'
	'fis-index-block' is a required property
	'partitions-table-offset' is a required property
	'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: '^partition-.*$', 'pinctrl-[0-9]+'
	False schema does not allow 1
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand-controller@1800: nand@0:partitions:compatible: 'oneOf' conditional failed, one must be fixed:
		['brcm,bcm4908-partitions'] is too short
		'fixed-partitions' was expected
		'sercomm,sc-partitions' was expected
	'arm,arm-firmware-suite' was expected
	'brcm,bcm947xx-cfe-partitions' was expected
	'linksys,ns-partitions' was expected
	'qcom,smem-part' was expected
	'redboot-fis' was expected
	'tplink,safeloader-partitions' was expected
	Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'compatible', 'mac@106a0' were unexpected)
	['nvmem-cells'] is too short
	'brcm,bcm4908-firmware' was expected
	'linksys,ns-firmware' was expected
	Unevaluated properties are not allowed ('compatible' was unexpected)
	['brcm,bcm4908-firmware'] is too short
	from schema $id: http://devicetree.org/schemas/mtd/brcm,brcmnand.yaml#
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand-controller@1800: Unevaluated properties are not allowed ('#address-cells', '#size-cells' were unexpected)
	from schema $id: http://devicetree.org/schemas/mtd/brcm,brcmnand.yaml#
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand-controller@1800: nand@0:partitions: 'oneOf' conditional failed, one must be fixed:
	'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: 'pinctrl-[0-9]+'
	'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: '^partition-[0-9a-z]+$', 'pinctrl-[0-9]+'
	'fis-index-block' is a required property
	'partitions-table-offset' is a required property
	'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: '^partition-.*$', 'pinctrl-[0-9]+'
	False schema does not allow 1
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand-controller@1800: nand@0:partitions:compatible: 'oneOf' conditional failed, one must be fixed:
		['brcm,bcm4908-partitions'] is too short
		'fixed-partitions' was expected
		'sercomm,sc-partitions' was expected
	'arm,arm-firmware-suite' was expected
	'brcm,bcm947xx-cfe-partitions' was expected
	'linksys,ns-partitions' was expected
	'qcom,smem-part' was expected
	'redboot-fis' was expected
	'tplink,safeloader-partitions' was expected
	Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'compatible', 'mac@106a0' were unexpected)
	['nvmem-cells'] is too short
	'brcm,bcm4908-firmware' was expected
	'linksys,ns-firmware' was expected
	Unevaluated properties are not allowed ('compatible' was unexpected)
	['brcm,bcm4908-firmware'] is too short
	from schema $id: http://devicetree.org/schemas/mtd/nand-controller.yaml#
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand@0: partitions: 'oneOf' conditional failed, one must be fixed:
	'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: 'pinctrl-[0-9]+'
	'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: '^partition-[0-9a-z]+$', 'pinctrl-[0-9]+'
	'fis-index-block' is a required property
	'partitions-table-offset' is a required property
	'#address-cells', '#size-cells', 'partition@0', 'partition@100000', 'partition@6080000' do not match any of the regexes: '^partition-.*$', 'pinctrl-[0-9]+'
	False schema does not allow 1
arch/arm64/boot/dts/broadcom/bcmbca/bcm4906-zyxel-ex3510b.dtb: nand@0: partitions:compatible: 'oneOf' conditional failed, one must be fixed:
		['brcm,bcm4908-partitions'] is too short
		'fixed-partitions' was expected
		'sercomm,sc-partitions' was expected
	'arm,arm-firmware-suite' was expected
	'brcm,bcm947xx-cfe-partitions' was expected
	'linksys,ns-partitions' was expected
	'qcom,smem-part' was expected
	'redboot-fis' was expected
	'tplink,safeloader-partitions' was expected
	Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'compatible', 'mac@106a0' were unexpected)
	['nvmem-cells'] is too short
	'brcm,bcm4908-firmware' was expected
	'linksys,ns-firmware' was expected
	Unevaluated properties are not allowed ('compatible' was unexpected)
	['brcm,bcm4908-firmware'] is too short
	from schema $id: http://devicetree.org/schemas/mtd/raw-nand-chip.yaml#