Re: [PATCH] firmware: arm_scmi: Skip opp duplicates
From: Cristian Marussi
Date: Thu Oct 10 2024 - 11:18:46 EST
On Thu, Oct 10, 2024 at 04:43:06PM +0200, Johan Hovold wrote:
> [ There appears to be something wrong with you mail setup as the patch
> had a bogus Reply-To header:
>
> Reply-To: 20241007060642.1978049-3-quic_sibis@xxxxxxxxxxx
> ]
>
Hi Johan,
unfortunately the setup that is wrong is indeed on the other side of the
screen (i.e. in my brain :D)...since I mistakenly added a --reply-to= instead
of the --in-reply-to= when trying to post with git send-email this patch
against Sibi original thread (which is the bogus message id above)
Apologies...
> On Wed, Oct 09, 2024 at 03:39:05PM +0100, Cristian Marussi wrote:
> > Buggy firmware can reply with duplicated PERF opps descriptors.
> >
> > Ensure that the bad duplicates reported by the platform firmware doesn't
> > get added to the opp-tables.
> >
> > Reported-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
> > Closes: https://lore.kernel.org/lkml/ZoQjAWse2YxwyRJv@xxxxxxxxxxxxxxxxxxxx/
> > Signed-off-by: Cristian Marussi <cristian.marussi@xxxxxxx>
> > ---
> > A new version to include in this series that should address the limit case
> > described by Sibi...not tested, of course :P
>
> Thanks for the fix. This seems to do the trick and gets rid of the
> warnings about duplicate entries on boot and resume (including the
> debugfs errors).
>
> Tested-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
Thanks for testing !
Cristian