Re: [PATCH v8 07/25] x86/resctrl: Introduce the interface to display monitor mode

[Moger, Babu]

Hi Tony,

On 10/10/24 10:07, Luck, Tony wrote:
>>>> +  By default resctrl assumes each control and monitor group has a hardware
>>>> +  counter. Hardware that does not support 'mbm_cntr_assign' mode will still
>>>> +  allow more control or monitor groups than 'num_rmids' to be created. In
>>>
>>> Should that be s/num_rmids/num_mbm_cntrs/ ?
>>
>> It is actually num_rmids here as in default mode, num_rmid_cntrs are not
>> available.
> 
> Babu,
> 
> The code isn't working that way for me. I built & booted. Since I'm on
> an Intel machine without ABMC I'm in "default" mode. But I can't make
> more monitor groups that num_rmids.
> 

That is correct. We will have to change the text. How about?

"default":
By default resctrl assumes each control and monitor group has a hardware
counter. Hardware that does not support 'mbm_cntr_assign' mode will still
allow to create control or monitor groups up to num_rmids supported. In
that case reading the mbm_total_bytes and mbm_local_bytes may report
'Unavailable' if there is no counter associated with that group.

-- 
Thanks
Babu Moger