Re: [PATCH 1/1] selftests: livepatch: add test cases of stack_order sysfs interface
From: Josh Poimboeuf
Date: Thu Oct 10 2024 - 11:51:37 EST
On Thu, Oct 10, 2024 at 11:11:56PM +0800, zhang warden wrote:
> > IIUC, you only need to test the stack order by loading LP modules. In
> > this case you could use our currently existing LP testing module for
> > that, right? That's what we currently do when testing different sysfs
> > attributes.
> >
>
> Yes, in fact, those three module I submitted is reuse the existing LP
> testing module of 'test_klp_livepatch'. Because I found some module
> in test module set "klp_replace" attribute true. If a module set this
> attribute true, it will disable the previous module.
>
> What's more, testing this 'stack_order' attribute need more than one
> module, hoping to change the same function. And breaking the '.replace'
> value of existing module may not be a good way. So I decided to copy
> more test module with '.replace=false' and this module is changing
> the same function.
Maybe add a replace=[true|false] module parameter.
--
Josh