RE: [PATCH v8 08/25] x86/resctrl: Introduce interface to display number of monitoring counters

From: Luck, Tony
Date: Thu Oct 10 2024 - 13:09:08 EST


Babu,

> We have the information already in r->mon.mbm_cntr_free_map.
>
> How about adding an extra text while printing num_mbm_cntrs?
>
> $ cat /sys/fs/resctrl/info/L3_MON/num_mbm_cntrs
> Total 32, Available 16

Either that or:
Total 32
Available 16

which looks fractionally simpler to parse. But I don't have strong feelings.

> There are all global counters, we don't differentiate between sockets just
> like number of CLOSIDs.

Interesting. So there is no real benefit from "0=tl;1=_" ... you are using
up two counters, just not reporting them on socket 1.

Why have this complexity in mbm_assign_control syntax?

You could have just {grouppath}/{allocation}

where allocation is one of _, t, l, tl

-Tony