Re: [PATCH v3] irqchip/renesas-rzg2l: Fix missing put_device

[Geert Uytterhoeven]

Hi Markus,

On Thu, Oct 10, 2024 at 7:53 PM Markus Elfring <Markus.Elfring@xxxxxx> wrote:
> > rzg2l_irqc_common_init calls of_find_device_by_node, but the
> > corresponding put_device call is missing.
> >
> > Make sure we call put_device when failing.
> >
> > "make coccicheck" will complain about a missing put_device before
> > successfully returning from rzg2l_irqc_common_init, however, that's
> > a false positive.
> >
> > Fixes: 3fed09559cd8 ("irqchip: Add RZ/G2L IA55 Interrupt Controller driver")
>
> Might the application of scope-based resource management become more
> interesting accordingly?

No, as explained in the comments:

> > +       /*
> > +        * coccicheck complains about a missing put_device call before returning, but it's a false
> > +        * positive. We still need &pdev->dev after successfully returning from this function.
> > +        */

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds