Re: [PATCH 2/2] arm64: dts: qcom: Enable USB controllers for QCS8300

[Dmitry Baryshkov]

On Thu, 10 Oct 2024 at 19:28, Krishna Kurapati
<quic_kriskura@xxxxxxxxxxx> wrote:
>
>
>
> On 10/10/2024 9:34 PM, Dmitry Baryshkov wrote:
> > On Thu, Oct 10, 2024 at 01:26:36AM GMT, Krishna Kurapati wrote:
> >> Enable primary USB controller on QCS8300 Ride platform and
> >> set the dr mode to peripheral mode.
> >>
> >> Signed-off-by: Krishna Kurapati <quic_kriskura@xxxxxxxxxxx>
> >> ---
> >>   arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 23 +++++++++++++++++++++++
> >>   1 file changed, 23 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> >> index 7eed19a694c3..3e925228379c 100644
> >> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> >> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> >> @@ -265,3 +265,26 @@ &ufs_mem_phy {
> >>      vdda-pll-supply = <&vreg_l5a>;
> >>      status = "okay";
> >>   };
> >> +
> >> +&usb_1_hsphy {
> >> +    vdda-pll-supply = <&vreg_l7a>;
> >> +    vdda18-supply = <&vreg_l7c>;
> >> +    vdda33-supply = <&vreg_l9a>;
> >> +
> >> +    status = "okay";
> >> +};
> >> +
> >> +&usb_qmpphy {
> >> +    vdda-phy-supply = <&vreg_l7a>;
> >> +    vdda-pll-supply = <&vreg_l5a>;
> >> +
> >> +    status = "okay";
> >> +};
> >> +
> >> +&usb_1 {
> >> +    status = "okay";
> >> +};
> >> +
> >> +&usb_1_dwc3 {
> >> +    dr_mode = "peripheral";
> >
> > Is it actually USB peripheral only? Or USB-C which isn't handled yet?
> >
>
> It is DRD capable. This platform has Type-A ports. I didn't see any way
> of role switching. So I hardcoded it to peripheral like on SA8775P and
> SA8540P ride platforms.

Type-A are usually host rather than peripheral. Please describe your
decisions in the commit message.

>
> Regards,
> Krishna,
>
> >> +};
> >> --
> >> 2.34.1
> >>
> >



-- 
With best wishes
Dmitry