Re: [PATCH v2 1/1] iio: imu: bmi270: Add spi driver for bmi270 imu

[Jonathan Cameron]

On Tue,  1 Oct 2024 23:36:22 -0400
Alex Lanzano <lanzano.alex@xxxxxxxxx> wrote:

> Implement SPI driver for the Bosch BMI270 6-axis IMU. Provide raw read
> write access to acceleration and angle velocity measurements via the SPI
> interface on the device.
> 
> Signed-off-by: Alex Lanzano <lanzano.alex@xxxxxxxxx>

Hi Alex,

Applied with one minor tweak. See below.

Applied to the togreg branch of iio.git and pushed out as testing for 0-day
to poke at it and see if we missed anything.

Thanks,

Jonathan

p.s. Thought I'd sent this already - hence I actually applied this last weekend :(

>  struct bmi270_data {
> diff --git a/drivers/iio/imu/bmi270/bmi270_core.c b/drivers/iio/imu/bmi270/bmi270_core.c
> index 8e45343d6472..638ce2c30d0e 100644
> --- a/drivers/iio/imu/bmi270/bmi270_core.c
> +++ b/drivers/iio/imu/bmi270/bmi270_core.c
> @@ -66,12 +66,6 @@ enum bmi270_scan {
>  	BMI270_SCAN_GYRO_Z,
>  };
>  
> -const struct regmap_config bmi270_regmap_config = {
> -	.reg_bits = 8,
> -	.val_bits = 8,
> -};
> -EXPORT_SYMBOL_NS_GPL(bmi270_regmap_config, IIO_BMI270);
> -
>  static int bmi270_get_data(struct bmi270_data *bmi270_device,
>  			   int chan_type, int axis, int *val)
>  {
> @@ -90,7 +84,9 @@ static int bmi270_get_data(struct bmi270_data *bmi270_device,
>  		return -EINVAL;
>  	}
>  
> -	ret = regmap_bulk_read(bmi270_device->regmap, reg, &sample, sizeof(sample));
> +	ret = regmap_bulk_read(bmi270_device->regmap, reg,
> +			       &sample,
> +			       sizeof(sample));
Trivial but this is an unrelated change.  Possibly valid but doesn't belong
in this patch set. I'll drop it whilst applying.

>  	if (ret)
>  		return ret;
>