Re: [PATCH] parisc: lba_pci: remove unused macro

[Helge Deller]

Hello Ba Jing,

On 10/8/24 09:26, Ba Jing wrote:
> By reading the code, I found the macro LBA_MASTER_ABORT_ERROR
> is never referenced in the code. Just remove it.

Thanks for your patch!

Of course you are right and this macro/constant is currently
unused, but it may become very useful when trying to debug this
code. In that case it's good to know that value without need to
look everything up again.

So, as there is not much gain in dropping this constant I plan
to keep it here and will not apply your patch.

Similar for the other patch you sent.

Anyway, thanks for spotting this. Maybe you find other more
useful possible code optimizations.

Helge


> Signed-off-by: Ba Jing <bajing@xxxxxxxxxxxxxxxxxxxx>
> ---
>   drivers/parisc/lba_pci.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/parisc/lba_pci.c b/drivers/parisc/lba_pci.c
> index 3fc3765fddaa..5990766b6561 100644
> --- a/drivers/parisc/lba_pci.c
> +++ b/drivers/parisc/lba_pci.c
> @@ -277,7 +277,6 @@ static int lba_device_present(u8 bus, u8 dfn, struct lba_device *d)
>    *		smart mode as well.
>    */
>
> -#define LBA_MASTER_ABORT_ERROR 0xc
>   #define LBA_FATAL_ERROR 0x10
>
>   #define LBA_CFG_MASTER_ABORT_CHECK(d, base, tok, error) {		\