Re: [PATCH v2] PCI: Introduce Cray ClusterStor E1000 NVMe slot LED driver

[Bjorn Helgaas]

On Thu, Oct 10, 2024 at 11:53:42AM -0700, Tony Hutter wrote:
> > I don't quite understand what the E1000 is and where this code
> > runs.  Since you have a DMI check for DMI_PRODUCT_NAME "VSSEP1EC",
> > I assume E1000 is an attached storage controller, and this driver
> > is part of an embedded OS running inside the E1000 itself, *not*
> > on the system to which the E1000 is attached?
> 
> You can think of an E1000 as a standard rack mount storage server
> with 24 NVMe slots.  They are often used as Lustre servers.  The DMI
> check makes sure the E1000 LED driver can only be loaded on E1000
> boards.  The driver is running on the main system (where Lustre
> runs) rather than a embedded storage controller. The driver does
> communicate with a embedded controller via IPMI to control the LEDs
> though.
> 
> I'm currently on baby bonding leave, but I'll try to implement your
> review comments into a version 3 patch once I get back into the
> office.

Congratulations!  Hope your family is all doing well!

Bjorn