Re: [PATCH 5/7] linux-kbuild: fix: implement choice for kconfigs

From: David Hunter
Date: Thu Oct 10 2024 - 16:06:26 EST


On 9/23/24 23:46, Masahiro Yamada wrote:

This is ugly.
Please do not use the temp file.



Understood. I found a way to do it that is much more in line with the style of the script and it avoids using the temp file. Oddly enough it involves changing less lines of code as well. I will be submitting the changes soon. Right now, I am just finishing up the change logs for all the patches.

My question here is "Is there a general rule as to why the first version was bad?" For example, is it considered bad practice to make temporary files?

Thanks,
David Hunter