Re: [PATCH net-next v20 01/14] mm: page_frag: add a test module for page_frag

[Shuah Khan]

On 10/8/24 21:59, Yunsheng Lin wrote:
> On 2024/10/9 3:56, Shuah Khan wrote:
> > On 10/8/24 05:20, Yunsheng Lin wrote:
> > > The testing is done by ensuring that the fragment allocated
> > > from a frag_frag_cache instance is pushed into a ptr_ring
> > > instance in a kthread binded to a specified cpu, and a kthread
> > > binded to a specified cpu will pop the fragment from the
> > > ptr_ring and free the fragment.
> > >
> > > CC: Alexander Duyck <alexander.duyck@xxxxxxxxx>
> > > Signed-off-by: Yunsheng Lin <linyunsheng@xxxxxxxxxx>
> > > Reviewed-by: Alexander Duyck <alexanderduyck@xxxxxx>
> >
> > Signed-off-by should be last. Same comment on all the other
>
> Hi, Shuah
>
> I used 'git am' to collect those tag, it seems that is the order
> the tool applied, and I checking other applied commit, it seems
> only Signed-off-by from the committer is the last, like the below
> recent mm commit:
> 6901cf55de22
> ff7f5ad7bce4

okay.

> > patches in this series. When you have 4 patches, it is a good
> > practice to add cover-letter.
>
> I guess the cover-letter meant below?
> https://lore.kernel.org/all/20241008112049.2279307-1-linyunsheng@xxxxxxxxxx/

Somehow this isn't in my Inbox.

> >

[snip]

> ...
>
> > > +function run_manual_check()
> > > +{
> > > +    #
> > > +    # Validate passed parameters. If there is wrong one,
> > > +    # the script exists and does not execute further.
> > > +    #
> > > +    validate_passed_args $@
> > > +
> > > +    echo "Run the test with following parameters: $@"
> >
> > Is this marker good enough to isolate the test results in the
> > dmesg? Include the test name in the message.
> >
> >
> > > +    insmod $DRIVER $@ > /dev/null 2>&1
> > > +    echo "Done."
> >
> > Is this marker good enough to isolate the test results in the
> > dmesg? Include the test name in the message.
> >
> > > +    echo "Check the kernel ring buffer to see the summary."
> >
> > Usually the test would run dmesg and filter out the test results
> > from the dmesg and include them in the test script output.
> >
> > You can refer to other tests that do that: powerpc/scripts/hmi.sh
> > is one example.
>
> Thanks, will check that.

thanks,
-- Shuah