Re: [PATCH v4] XArray: minor documentation improvements
From: Randy Dunlap
Date: Thu Oct 10 2024 - 17:50:42 EST
On 10/10/24 2:41 PM, Tamir Duberstein wrote:
> - Replace "they" with "you" where "you" is used in the preceding
> sentence fragment.
> - Mention `xa_erase` in discussion of multi-index entries. Split this
> into a separate sentence.
> - Add "call" parentheses on "xa_store" for consistency and
> linkification.
> - Add caveat that `xa_store` and `xa_erase` are not equivalent in the
> presence of `XA_FLAGS_ALLOC`.
>
> Signed-off-by: Tamir Duberstein <tamird@xxxxxxxxx>
> ---
> V3 -> V4: Remove latent sentence fragment.
> V2 -> V3:
> - metion `xa_erase`/`xa_store(NULL)` in multi-index entry discussion.
> - mention non-equivalent of `xa_erase`/`xa_store(NULL)` in the
> presence of `XA_FLAGS_ALLOC`.
> V1 -> V2: s/use/you/ (Darrick J. Wong)
>
> Documentation/core-api/xarray.rst | 24 +++++++++++++-----------
> 1 file changed, 13 insertions(+), 11 deletions(-)
>
I'm satisfied with this change although obviously it's up to Matthew.
Thanks.
Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
--
~Randy