Re: [PATCH] function_graph: no need to invoke the function call_filter_check_discard

[Steven Rostedt]

On Thu, 10 Oct 2024 11:58:26 +0800
Donglin Peng <dolinux.peng@xxxxxxxxx> wrote:

> From: Donglin Peng <pengdonglin@xxxxxxxxxx>
> 
> The function call_filter_check_discard has been removed in the
> commit [1].
> 
> [1] https://lore.kernel.org/all/20240911010026.2302849-1-zhengyejian@xxxxxxxxxxxxxxx/
> 
> Signed-off-by: Donglin Peng <dolinux.peng@xxxxxxxxx>
> ---
>  kernel/trace/trace_functions_graph.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c
> index 3b210e6bcd70..98f347c049d2 100644
> --- a/kernel/trace/trace_functions_graph.c
> +++ b/kernel/trace/trace_functions_graph.c
> @@ -148,8 +148,7 @@ int __trace_graph_retaddr_entry(struct trace_array *tr,
>  	entry->graph_ent.func = trace->func;
>  	entry->graph_ent.depth = trace->depth;
>  	entry->graph_ent.retaddr = retaddr;
> -	if (!call_filter_check_discard(call, entry, buffer, event))
> -		trace_buffer_unlock_commit_nostack(buffer, event);
> +	trace_buffer_unlock_commit_nostack(buffer, event);
>  
>  	return 1;
>  }

This still fails:

kernel/trace/trace_functions_graph.c:140:27: error: unused variable 'call' [-Werror,-Wunused-variable]
  140 |         struct trace_event_call *call = &event_fgraph_retaddr_entry;
      |                                  ^~~~
1 error generated.

I'll just fix it up.

Thanks,

-- Steve