RE: [PATCH v3 00/22] wifi: nxpwifi: create nxpwifi to support iw61x
From: David Lin
Date: Thu Oct 10 2024 - 20:53:39 EST
Hi Kalle,
There is no more comments for nxpwifi patch v3 till now. I wonder if I can
create the single patch for final review?
Thanks & Regards,
David
> From: David Lin <yu-hao.lin@xxxxxxx>
> Sent: Monday, September 30, 2024 2:37 PM
> To: linux-wireless@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx; briannorris@xxxxxxxxxxxx;
> kvalo@xxxxxxxxxx; francesco@xxxxxxxxxx; Pete Hsieh
> <tsung-hsien.hsieh@xxxxxxx>; s.hauer@xxxxxxxxxxxxxx; David Lin
> <yu-hao.lin@xxxxxxx>
> Subject: [PATCH v3 00/22] wifi: nxpwifi: create nxpwifi to support iw61x
>
> This series adds support for IW61x which is a new family of 2.4/5 GHz
> dual-band 1x1 Wi-Fi 6, Bluetooth/Bluetooth Low Energy 5.2 and 15.4
> tri-radio single chip by NXP. These devices support 20/40/80MHz single
> spatial stream in both STA and AP mode. Communication to the IW61x is
> done via SDIO interface
>
> This driver is a derivative of existing Mwifiex [1] and based on full-MAC
> architecture [2]. It has been tested with i.MX8M Mini evaluation kits in both
> AP and STA mode.
>
> All code passes sparse and checkpatch.
>
> Data sheet (require registration):
> https://www.nxp.com/products/wireless-connectivity/wi-fi-plus-bluetooth-
> plus-802-15-4/2-4-5-ghz-dual-band-1x1-wi-fi-6-802-11ax-plus-bluetooth-5-
> 4-plus-802-15-4-tri-radio-solution:IW612
>
> This patch intents to add new driver nxpwifi for NXP IW61x and future new
> chips/features support.
>
> [1] We had considered adding IW61x to mwifiex, however due to FW
> architecture, host command interface and supported features are
> significantly different, doing this on mwifiex will carry a lot of
> burdens. The effort of making sure no regression is also a huge effort.
> We must create a new driver nxpwifi. Subsequent NXP chipsets will be
> added and sustained on nxpwifi only.
>
> [2] Some features, as of now, WPA2/WPA3 personal/enterprise are offloaded
> to host wpa_supplicant/hostapd.
>
> v3:
> - Enable 802.11ax (Wi-Fi 6) for both AP and STA mode.
> - Extend driver verion string with hotfix number.
> - Remove Rx mlme work.
> - Remove all useless check of netif_carrier_ok().
> - Merge decl.h to cfg.h.
> - Remove unnecessary check for wiphy parameters setting.
> - Synchronize following commits from Mwifiex:
> wifi: mwifiex: replace open-coded module_sdio_driver()
> wifi: mwifiex: Fix interface type change
> wifi: mwifiex: Do not return unused priv in mwifiex_get_priv_by_id()
> wifi: mwifiex: increase max_num_akm_suites
> wifi: mwifiex: duplicate static structs used in driver instances
> wifi: mwifiex: keep mwifiex_cfg80211_ops constant
> wifi: mwifiex: Fix uninitialized variable in
> mwifiex_cfg80211_authenticate()
> wifi: mwifiex: remove unnecessary checks for valid priv
> wifi: mwifiex: Fix memcpy() field-spanning write warning in
> mwifiex_cmd_802_11_scan_ext()
> wifi: mwifiex: Use IRQF_NO_AUTOEN flag in request_irq()
>
> v2:
> - Rename ioctl.h and sta_ioctl.c to cfg.h and sta_cfg.c.
> - Remove useless header file semaphore.h.
> - Use static variable for cookie.
> - Modify nxpwifi_register to use ERR_PTR, IS_ERR and PTR_ERR.
> - Use error number for error code.
> - Remove unnecessary private ie definitions.
> - Remove mutex async_mutex and related code.
> - Remove unnecessary work queue.
> - Add the support for PSK SHA256.
> - Use tasklet for Rx.
> - Remove unused functions.
> - Remove compile warning.
>