Re: [PATCHv6 bpf-next 16/16] selftests/bpf: Add threads to consumer test

[Andrii Nakryiko]

On Thu, Oct 10, 2024 at 1:13 PM Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
>
> With recent uprobe fix [1] the sync time after unregistering uprobe is
> much longer and prolongs the consumer test which creates and destroys
> hundreds of uprobes.
>
> This change adds 16 threads (which fits the test logic) and speeds up
> the test.
>
> Before the change:
>
>   # perf stat --null ./test_progs -t uprobe_multi_test/consumers
>   #421/9   uprobe_multi_test/consumers:OK
>   #421     uprobe_multi_test:OK
>   Summary: 1/1 PASSED, 0 SKIPPED, 0 FAILED
>
>    Performance counter stats for './test_progs -t uprobe_multi_test/consumers':
>
>         28.818778973 seconds time elapsed
>
>          0.745518000 seconds user
>          0.919186000 seconds sys
>
> After the change:
>
>   # perf stat --null ./test_progs -t uprobe_multi_test/consumers 2>&1
>   #421/9   uprobe_multi_test/consumers:OK
>   #421     uprobe_multi_test:OK
>   Summary: 1/1 PASSED, 0 SKIPPED, 0 FAILED
>
>    Performance counter stats for './test_progs -t uprobe_multi_test/consumers':
>
>          3.504790814 seconds time elapsed
>
>          0.012141000 seconds user
>          0.751760000 seconds sys
>
> [1] commit 87195a1ee332 ("uprobes: switch to RCU Tasks Trace flavor for better performance")
>
> Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> ---
>  .../bpf/prog_tests/uprobe_multi_test.c        | 98 +++++++++++++++----
>  1 file changed, 80 insertions(+), 18 deletions(-)
>

OK, LGTM

Acked-by: Andrii Nakryiko <andrii@xxxxxxxxxx>

[...]