Re: [PATCH v1 04/10] media: platform: mediatek: add isp_7x cam-raw unit

[CK Hu (胡俊光)]

Hi, Shu-hsiang:

On Wed, 2024-10-09 at 19:15 +0800, Shu-hsiang Yang wrote:
> Introduces the ISP pipeline driver for the MediaTek ISP raw and yuv
> modules. Key functionalities include data processing, V4L2 integration,
> resource management, debug support, and various control operations.
> Additionally, IRQ handling, platform device management, and MediaTek
> ISP DMA format support are also included.
> 
> Signed-off-by: Shu-hsiang Yang <Shu-hsiang.Yang@xxxxxxxxxxxx>
> ---

[snip]

> +
> +/* feature mask to categorize all raw functions */
> +#define MTK_CAM_FEATURE_HDR_MASK		0x0000000F
> +#define MTK_CAM_FEATURE_SUBSAMPLE_MASK		0x000000F0
> +#define MTK_CAM_FEATURE_OFFLINE_M2M_MASK	0x00000100
> +#define MTK_CAM_FEATURE_PURE_OFFLINE_M2M_MASK	0x00000200

It seems that M2M is not basic function. It's an advanced function, so separate M2M related code to an independent patch.
Make the first patch as simple as possible.

Regards,
CK

> +
> +enum raw_function_id {
> +	/* bit [0~3] hdr */
> +	/* bit [4~7] fps */
> +	/* bit [8~9] m2m */
> +	OFFLINE_M2M			= (1 << 8),
> +	PURE_OFFLINE_M2M		= (1 << 9),
> +	RAW_FUNCTION_END		= 0xF0000000,
> +};
> +