Re: [PATCH 2/4] dt-bindings: arm-smmu: Document Qualcomm QCS615 apps smmu

[Krzysztof Kozlowski]

On 11/10/2024 08:31, Qingqing Zhou wrote:
> Add devicetree binding for apps smmu on Qualcomm QCS615 SoC. SMMU function
> is required by multiple functions including USB/UFS/Ethernet.

Do not explain what SMMU is, because it is obvious, but explain how this
hardware differs from everything existing.

> 
> Signed-off-by: Qingqing Zhou <quic_qqzhou@xxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> index 92d350b8e01a..9e62c2cdda08 100644
> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> @@ -36,6 +36,7 @@ properties:
>          items:
>            - enum:
>                - qcom,qcm2290-smmu-500
> +              - qcom,qcs615-smmu-500

This is incomplete? No clocks? No power-domains?

Best regards,
Krzysztof