Re: [PATCH] leds: Fix uninitialized variable 'ret' in mt6370_mc_pattern_clear
From: Lee Jones
Date: Fri Oct 11 2024 - 03:47:46 EST
On Sun, 06 Oct 2024, SurajSonawane2415 wrote:
> Fix the uninitialized symbol 'ret' in the function mt6370_mc_pattern_clear
> to resolve the following warning:
> drivers/leds/rgb/leds-mt6370-rgb.c:604 mt6370_mc_pattern_clear()
> error: uninitialized symbol 'ret'.
> Initialize 'ret' to 0 to prevent undefined behavior from uninitialized
> access.
>
> Signed-off-by: SurajSonawane2415 <surajsonawane0215@xxxxxxxxx>
Real names only. Please update your .gitconfig.
> ---
> drivers/leds/rgb/leds-mt6370-rgb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/rgb/leds-mt6370-rgb.c b/drivers/leds/rgb/leds-mt6370-rgb.c
> index 10a0b5b45..87805c21e 100644
> --- a/drivers/leds/rgb/leds-mt6370-rgb.c
> +++ b/drivers/leds/rgb/leds-mt6370-rgb.c
> @@ -587,7 +587,7 @@ static inline int mt6370_mc_pattern_clear(struct led_classdev *lcdev)
> struct mt6370_led *led = container_of(mccdev, struct mt6370_led, mc);
> struct mt6370_priv *priv = led->priv;
> struct mc_subled *subled;
> - int i, ret;
> + int i, ret = 0;
>
> mutex_lock(&led->priv->lock);
>
> --
> 2.34.1
>
--
Lee Jones [李琼斯]